Add custom window constructor#125
Closed
idanrozin wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
Closed
Add custom window constructor#125idanrozin wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
idanrozin wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
Conversation
added 2 commits
December 30, 2022 15:27
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Thanks for the PR @idanrozin, any reason why you closed it? Signign the CLA is standard to contribute to Google-own code. |
Collaborator
|
Ah sorry I see #126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, related to issue #124 I have opened a PR for whomever is interested. hope it helps and someone will take it to review and merge :)
regarding the tests. I know it looks awful in the diff view but what I essentialy did is just to create another test suite which runs the same tests but with the new constructor edition. so i needed to extract the funcitons logic outside and use closure on some. but basically this is the structure:
before each (the only change here is the instantiation of
StackdriverErrorReporterand window which is done inside the tests suites itself.first suite -> same logic
second suite -> same logic just with
new StackdriverErrorReporter(customWindow)Thanks!